-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the experimental Utf8String type and tests from the runtime repo #44574
Conversation
Tagging subscribers to this area: @ViktorHofer Issue meta data
|
Don't forget to remove the file runtime/src/libraries/System.Private.CoreLib/src/System/Char8.cs and all references to the Char8 type. If you search the repo's .cs files for FEATURE_UTF8STRING, you'll find some lingering references in Utf8Utility.cs, Span.cs, Memory.cs, and related files. Those can all be removed as well. |
Merging now to unblock my follow-up Crossgen2 efforts. I'll be happy to address any additional feedback in a follow-up PR. |
I'm proposing to remove the Utf8String and Utf8Span types and the
System.Utf8String.Experimental tests from the runtime repo as according to
JanK's clarifications these types and tests are currently treated as experimental
and belong to the runtimelab, not to the "production" runtime repo. From a
practical perspective, we're hitting crashes in the Utf8String tests when using
System.Private.CoreLib compiled with Crossgen2 which doesn't yet implement
the Utf8String-related typesystem logic.
Thanks
Tomas
Related to: #41521